Raise on ruby 2.7 deprecation warnings

.github/workflows/ci.yml

@@ -88,6 +88,7 @@ jobs:
         run: |
           docker run \
             --env "CI=true" \
+            --env "RAISE_ON_WARNINGS=true" \
             --env "DEPENDABOT_TEST_ACCESS_TOKEN=${{ secrets.GITHUB_TOKEN }}" \
             --env "SUITE_NAME=${{ matrix.suite.name }}" \
             --rm "$CORE_CI_IMAGE" bash -c \

common/lib/dependabot/clients/bitbucket_with_retries.rb

@@ -29,7 +29,7 @@ def self.for_bitbucket_dot_org(credentials:)
 
       def initialize(max_retries: 3, **args)
         @max_retries = max_retries || 3
-        @client = Bitbucket.new(args)
+        @client = Bitbucket.new(**args)
       end
 
       def method_missing(method_name, *args, &block)

common/spec/dependabot/dependency_spec.rb

@@ -5,7 +5,7 @@
 
 RSpec.describe Dependabot::Dependency do
   describe ".new" do
-    subject(:dependency) { described_class.new(args) }
+    subject(:dependency) { described_class.new(**args) }
 
     let(:args) do
       {
@@ -90,22 +90,22 @@
     end
 
     context "when two dependencies are equal" do
-      let(:dependency1) { described_class.new(args) }
-      let(:dependency2) { described_class.new(args) }
+      let(:dependency1) { described_class.new(**args) }
+      let(:dependency2) { described_class.new(**args) }
 
       specify { expect(dependency1).to eq(dependency2) }
     end
 
     context "when two dependencies are not equal" do
-      let(:dependency1) { described_class.new(args) }
-      let(:dependency2) { described_class.new(args.merge(name: "dep2")) }
+      let(:dependency1) { described_class.new(**args) }
+      let(:dependency2) { described_class.new(**args.merge(name: "dep2")) }
 
       specify { expect(dependency1).to_not eq(dependency2) }
     end
   end
 
   describe "#production?" do
-    subject(:production?) { described_class.new(dependency_args).production? }
+    subject(:production?) { described_class.new(**dependency_args).production? }
 
     let(:dependency_args) do
       {
@@ -141,7 +141,7 @@
   end
 
   describe "#display_name" do
-    subject(:display_name) { described_class.new(dependency_args).display_name }
+    subject(:display_name) { described_class.new(**dependency_args).display_name }
 
     let(:dependency_args) do
       {
@@ -155,7 +155,7 @@
   end
 
   describe "#to_h" do
-    subject(:to_h) { described_class.new(dependency_args).to_h }
+    subject(:to_h) { described_class.new(**dependency_args).to_h }
 
     context "with requirements" do
       let(:dependency_args) do
@@ -221,7 +221,7 @@
 
   describe "#subdependency_metadata" do
     subject(:subdependency_metadata) do
-      described_class.new(dependency_args).subdependency_metadata
+      described_class.new(**dependency_args).subdependency_metadata
     end
 
     let(:dependency_args) do

common/spec/dependabot/security_advisory_spec.rb

@@ -16,7 +16,7 @@
   let(:vulnerable_versions) { [Gem::Requirement.new(">= 1")] }
 
   describe ".new" do
-    subject(:security_advisory) { described_class.new(args) }
+    subject(:security_advisory) { described_class.new(**args) }
 
     let(:args) do
       {

common/spec/dependabot/source_spec.rb

@@ -5,7 +5,7 @@
 
 RSpec.describe Dependabot::Source do
   describe ".new" do
-    subject { described_class.new(attrs) }
+    subject { described_class.new(**attrs) }
 
     context "without a hostname or api_endpoint" do
       let(:attrs) { { provider: "github", repo: "my/repo" } }
@@ -171,7 +171,7 @@
   end
 
   describe "#url_with_directory" do
-    let(:source) { described_class.new(attrs) }
+    let(:source) { described_class.new(**attrs) }
     subject { source.url_with_directory }
 
     let(:attrs) do

common/spec/spec_helper.rb

@@ -10,6 +10,7 @@
 
 require "dependabot/dependency_file"
 require_relative "dummy_package_manager/dummy"
+require_relative "warning_monkey_patch"
 
 if ENV["COVERAGE"]
   SimpleCov::Formatter::Console.output_style = "block"

common/spec/warning_monkey_patch.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+ALLOW_PATTERNS = [
+  # Ignore parser warnings for ruby 2.7 minor version mismatches
+  # TODO: Fix these by upgrading to ruby 2.7.3 (requires ubuntu upgrade)
+  %r{parser/current is loading parser/ruby27},
+  /2.7.\d-compliant syntax, but you are running 2.7.\d/,
+  %r{whitequark/parser}
+].freeze
+
+# Called internally by Ruby for all warnings
+module Warning
+  def self.warn(message)
+    $stderr.print(message)
+
+    raise message if ENV["RAISE_ON_WARNINGS"].to_s == "true" && ALLOW_PATTERNS.none? { |pattern| pattern =~ message }
+
+    return unless ENV["DEBUG_WARNINGS"]
+
+    warn caller
+    $stderr.puts
+  end
+end

gradle/spec/dependabot/gradle_spec.rb

@@ -9,7 +9,7 @@
 
   describe "Dependency#display_name" do
     subject(:display_name) do
-      Dependabot::Dependency.new(dependency_args).display_name
+      Dependabot::Dependency.new(**dependency_args).display_name
     end
 
     let(:dependency_args) do

maven/spec/dependabot/maven_spec.rb

@@ -9,7 +9,7 @@
 
   describe "Dependency#display_name" do
     subject(:display_name) do
-      Dependabot::Dependency.new(dependency_args).display_name
+      Dependabot::Dependency.new(**dependency_args).display_name
     end
 
     let(:dependency_args) do