Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to profile dry-run using Stackprof #3141

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Add option to profile dry-run using Stackprof #3141

merged 2 commits into from
Feb 15, 2021

Conversation

jurre
Copy link
Member

@jurre jurre commented Feb 15, 2021

This makes it easy to figure out performance bottlenecks by analyzing
where time is spent in a run. The trace can be visualized by running
stackprof --d3-flamegraph tmp/stackprof-2021-02-15-13:00.dump > tmp/flamegraph.html
and viewing that in a browser. For some reason the built in viewer did
not work on my machine, but the d3-generated flamegraph has been clear
enough for me.

This makes it easy to figure out performance bottlenecks by analyzing
where time is spent in a run. The trace can be visualized by running
`stackprof --d3-flamegraph tmp/stackprof-2021-02-15-13:00.dump > tmp/flamegraph.html`
and viewing that in a browser. For some reason the built in viewer did
not work on my machine, but the d3-generated flamegraph has been clear
enough for me.
@jurre jurre requested a review from a team as a code owner February 15, 2021 13:39
Copy link
Contributor

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

Python spec failure seems like a legit issue from flake8 trying to lint stackprof files in .bundle

@jurre jurre merged commit ad880ee into main Feb 15, 2021
@jurre jurre deleted the jurre/stackprof branch February 15, 2021 16:58
@thepwagner thepwagner mentioned this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants