Skip to content

Conversation

brrygrdn
Copy link
Contributor

@brrygrdn brrygrdn commented Aug 5, 2025

What are you trying to accomplish?

This fixes an experiment-only bug

When testing this experimental feature, I realised there was a slip up in the in unit tests and the method signature used in the update_files_command.rb was that of the api_client and not the service shim that sits in between the two.

updater | 2025/08/05 14:43:17 ERROR <job_1069005148> wrong number of arguments (given 1, expected 0)
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/sorbet-runtime-0.5.11952/lib/types/private/methods/signature.rb:204:in 'T::Private::Methods::Signature#each_args_value_type'
updater | 2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/sorbet-runtime-0.5.11952/lib/types/private/methods/call_validation.rb:227:in 'T::Private::Methods::CallValidation.validate_call'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/sorbet-runtime-0.5.11952/lib/types/private/methods/_methods.rb:277:in 'block in Dependabot::Service#_on_method_added'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:173:in 'Dependabot::UpdateFilesCommand#dependency_submission_experiment'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:43:in 'block in Dependabot::UpdateFilesCommand#perform_job'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/opentelemetry-api-1.5.0/lib/opentelemetry/trace/tracer.rb:37:in 'block in OpenTelemetry::Trace::Tracer#in_span'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/opentelemetry-api-1.5.0/lib/opentelemetry/trace.rb:70:in 'block in OpenTelemetry::Trace#with_span'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/opentelemetry-api-1.5.0/lib/opentelemetry/context.rb:88:in 'OpenTelemetry::Context.with_value'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/opentelemetry-api-1.5.0/lib/opentelemetry/trace.rb:70:in 'OpenTelemetry::Trace#with_span'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/vendor/ruby/3.4.0/gems/opentelemetry-api-1.5.0/lib/opentelemetry/trace/tracer.rb:37:in 'OpenTelemetry::Trace::Tracer#in_span'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:21:in 'Dependabot::UpdateFilesCommand#perform_job'
2025/08/05 14:43:17 ERROR <job_1069005148> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:37:in 'Dependabot::BaseCommand#run'

This fixes the test and method signature.

Anything you want to highlight for special attention from reviewers?

N/A

How will you know you've accomplished your goal?

When I run a new update for my experimental end-to-end test I will no longer see this error.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@brrygrdn brrygrdn requested a review from a team as a code owner August 5, 2025 15:01
@brrygrdn brrygrdn merged commit 7ae30d0 into main Aug 5, 2025
146 of 151 checks passed
@brrygrdn brrygrdn deleted the brrygrdn/dg-7122-fix-one-pipeline-experiment branch August 5, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants