-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Conda support (for python packages) #12767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
markhallen
merged 26 commits into
dependabot:main
from
theztefan:theztefan/conda-pip-support
Aug 6, 2025
Merged
Add Conda support (for python packages) #12767
markhallen
merged 26 commits into
dependabot:main
from
theztefan:theztefan/conda-pip-support
Aug 6, 2025
+7,068
−1,756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markhallen
reviewed
Aug 5, 2025
remove unnecessary comment Co-authored-by: Mark Allen <[email protected]>
remove unnecessary comment Co-authored-by: Mark Allen <[email protected]>
narrowing down exception handling Co-authored-by: Mark Allen <[email protected]>
Co-authored-by: Mark Allen <[email protected]>
Co-authored-by: Mark Allen <[email protected]>
remove commented out test Co-authored-by: Mark Allen <[email protected]>
markhallen
previously approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @theztefan
Co-authored-by: Mark Allen <[email protected]>
markhallen
approved these changes
Aug 6, 2025
This was referenced Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Raising this PR to add Conda support to
dependabot-core
and overall Dependabot on GitHub.com.Relevant Issues
#4369
#1249
Anything you want to highlight for special attention from reviewers?
Conda Implementation in
dependabot-core
Overview
What is the Conda Implementation?
The Conda ecosystem implementation in
dependabot-core
provides automated dependency management for Python packages specified in Condaenvironment.yml
files. This implementation focuses exclusively on Python packages while leveraging existing Python/PyPI infrastructure for maximum reliability and maintainability.Strategic Scope
✅ Supported:
❌ Explicitly Excluded:
Key Design Decisions
1. Python-Only Strategic Scope
Decision: Focus exclusively on Python packages from both conda and pip sources in Conda manifest files.
Rationale:
Implementation:
PythonPackageClassifier
with blocklist approach for distinguishable R and system tools but treat every dependency as python by default and delegate to the python implementation. Uses semantic dependency groups:groups: ["dependencies"]
for conda dependencies andgroups: ["pip"]
for pip dependencies, enabling clear separation and targeted updates.2. Delegation to Python Ecosystem
Decision: Delegate version checking to existing Python infrastructure instead of implementing conda-specific registry integration.
Rationale:
Implementation:
LatestVersionFinder
inherits fromPackageLatestVersionFinder
and delegates toPython::UpdateChecker::LatestVersionFinder
.3. String-Based File Updates
Decision: Use string replacement instead of YAML parsing/dumping for file updates.
Rationale:
Implementation: Sophisticated regex patterns that capture and preserve formatting.
4. Tiered Environment Support
Decision: Implement three-tier support model based on environment complexity.
Rationale:
Implementation:
fully_qualified_package?
detection via=
character counting.5. Beta Feature Flag Protection
Decision: Protect all functionality behind
allow_beta_ecosystems?
feature flag.Rationale:
Implementation: Feature flag check in
FileFetcher
with clear error messages.High-Level Architecture
dependabot-core
Architecture IntegrationThe Conda implementation follows
dependabot-core
standard four component architecture pattern:Python Ecosystem Delegation Strategy
Key point: Instead of reimplementing PyPI integration, the Conda implementation delegates version checking to the existing Python ecosystem infrastructure:
How will you know you've accomplished your goal?
dry-run
tests with gathered manifest files haveChecklist