Fix broken bundler updates from sources other than RubyGems or other gem repositories #12698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempt at this was wrong, as it would still fallback to using rubygems.org to try and get info. We should be returning an empty package details object as before dependabot#12465
markhallen
approved these changes
Jul 25, 2025
markhallen
added a commit
that referenced
this pull request
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fix #12697 by returning
nilinDependabot::Bundler::Package::PackageDetailsFetcher.get_url_from_dependencywhen the dependency's source type is eithergitorother, as both of these types are likely/certain to not have a valid RubyGems URL.This restores the previous behaviour from before the changes in #12465 without affecting those changes for dependencies from RubyGems or private gem repositories.
Anything you want to highlight for special attention from reviewers?
This seemed like the simplest change that would restore previous functionality without affecting the changes from #12465
How will you know you've accomplished your goal?
We will see our Dependabot updates working again instead of giving errors like the one described in the linked issue
Checklist