Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dotnet .slnx solution files (nuget), using Microsoft.VisualStudio.SolutionPersistence #11865

Merged
merged 8 commits into from
Apr 7, 2025

Conversation

sailro
Copy link
Contributor

@sailro sailro commented Mar 21, 2025

Note:

This is a port of an initial prototype made by @austindrenski using custom .slnx parsing. (thanks!)

Given the PR was stale for several weeks, I created this new one, following suggestions made by @brettfo, specifically using the official Microsoft.VisualStudio.SolutionPersistence API.

What are you trying to accomplish?

  • Adds support for the new .slnx solution format, using the official Microsoft.VisualStudio.SolutionPersistence API.
  • Update the existing .sln support to use this new API as well. As suggested, keep the existing code for .sln support.

Fixes: #11671

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

  • dependabot will work with repositories using this new file format.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sailro sailro requested a review from a team as a code owner March 21, 2025 09:04
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 21, 2025
@sailro
Copy link
Contributor Author

sailro commented Mar 21, 2025

cc @baronfel for awareness

@sailro sailro requested a review from baronfel March 21, 2025 16:54
Copy link

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@sailro
Copy link
Contributor Author

sailro commented Mar 25, 2025

cc @brettfo for awareness given he reviewed the initial prototype made by @austindrenski

@sailro sailro force-pushed the add-slnx-support branch from a7abb28 to a6118bd Compare March 28, 2025 08:01
Copy link

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @sailro!

Appreciate you taking up #11694 and running with it! (Tale as old as time: find an interesting self-contained task, open a shiny new PR for it, work gets crazy, shiny new PR languishes growing ever staler. A modern day tragedy, but also, an unavoidable cannon event, lol).

I'm going to close #11694 as using the official upstream parsing library is undeniably a more robust solution (no pun intended), less likely to break over time, etc.!

🚢🚢🚢🚢🚢

@sailro sailro force-pushed the add-slnx-support branch from a6118bd to 150e74a Compare April 3, 2025 09:06
brettfo
brettfo previously approved these changes Apr 4, 2025
Copy link
Contributor

@brettfo brettfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, thank you!

I see there are some conflicts. As soon as those are resolved ping me again (I get lots of GitHub notifications so directly mentioning me is your best bet) I'll re-approve to make the CI checks happy.

@sailro
Copy link
Contributor Author

sailro commented Apr 4, 2025

PR looks good, thank you!

I see there are some conflicts. As soon as those are resolved ping me again (I get lots of GitHub notifications so directly mentioning me is your best bet) I'll re-approve to make the CI checks happy.

Thank you @brettfo, we should be good now.

@randhircs randhircs merged commit d5a9d5a into dependabot:main Apr 7, 2025
58 checks passed
@sailro sailro deleted the add-slnx-support branch April 7, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot fails with a repository containing a dotnet project using a .slnx solution file
6 participants