-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dotnet .slnx solution files (nuget), using Microsoft.VisualStudio.SolutionPersistence
#11865
Conversation
cc @baronfel for awareness |
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DiscoveryWorker.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
cc @brettfo for awareness given he reviewed the initial prototype made by @austindrenski |
a7abb28
to
a6118bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @sailro!
Appreciate you taking up #11694 and running with it! (Tale as old as time: find an interesting self-contained task, open a shiny new PR for it, work gets crazy, shiny new PR languishes growing ever staler. A modern day tragedy, but also, an unavoidable cannon event, lol).
I'm going to close #11694 as using the official upstream parsing library is undeniably a more robust solution (no pun intended), less likely to break over time, etc.!
🚢🚢🚢🚢🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, thank you!
I see there are some conflicts. As soon as those are resolved ping me again (I get lots of GitHub notifications so directly mentioning me is your best bet) I'll re-approve to make the CI checks happy.
Thank you @brettfo, we should be good now. |
Note:
This is a port of an initial prototype made by @austindrenski using custom
.slnx
parsing. (thanks!)Given the PR was stale for several weeks, I created this new one, following suggestions made by @brettfo, specifically using the official
Microsoft.VisualStudio.SolutionPersistence
API.What are you trying to accomplish?
.slnx
solution format, using the officialMicrosoft.VisualStudio.SolutionPersistence
API.Update the existing. As suggested, keep the existing code for.sln
support to use this new API as well.sln
support.Fixes: #11671
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist