Fix dependency tag filtering to use exact prefix matching #10799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I am fixing an issue with dependency tag filtering in our release notes finder process. Currently, the system incorrectly identifies releases when unrelated tags contain the package name. I'm changing the tag filtering method from
included?
tostart_with?
to ensure more accurate matching.This change prevents false positives in release identification, ensuring that our automated dependency update process works correctly and doesn't miss important updates or include irrelevant ones.
Anything you want to highlight for special attention from reviewers?
The key change is in the tag filtering logic:
I chose this approach because it provides a more precise match for dependency tags. While using
included?
was too broad and led to false positives,start_with?
ensures we only match tags that explicitly start with the dependency name.Please pay special attention to the updated test cases, particularly the new fixture file
releases_with_mixed_tag_formats.json
, which aims to cover the tag naming scenarios.How will you know you've accomplished your goal?
Checklist