-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise when an unsupported package manager version is present #10794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kbukum1
force-pushed
the
hook-up-unsupported-package-managers
branch
2 times, most recently
from
October 15, 2024 21:53
8c9d418
to
ff563b7
Compare
kbukum1
force-pushed
the
hook-up-unsupported-package-managers
branch
from
October 15, 2024 22:08
ff563b7
to
71eab61
Compare
kbukum1
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Adding specs for update file commands
- Adding specs for dependency snapshots
- Removing unsupported package manager error from operations
honeyankit
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonabc
reviewed
Oct 15, 2024
jonabc
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When we parse the manifest files, if we come across an unsupported package manager version, we should immediately fail the job.
The idea is the customer will need to upgrade or remove the old manifest to get updates again. This keeps our code simple to maintain rather than trying to work around old outdated versions.
Anything you want to highlight for special attention from reviewers?
Most of this PR is implementing it in the "silent" ecosystem which is a dummy ecosystem used to test the updater.
How will you know you've accomplished your goal?
This change will cause bundler 1 jobs to start failing with a clear error message.
Checklist