Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise when an unsupported package manager version is present #10794

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Oct 15, 2024

What are you trying to accomplish?

When we parse the manifest files, if we come across an unsupported package manager version, we should immediately fail the job.

The idea is the customer will need to upgrade or remove the old manifest to get updates again. This keeps our code simple to maintain rather than trying to work around old outdated versions.

Anything you want to highlight for special attention from reviewers?

Most of this PR is implementing it in the "silent" ecosystem which is a dummy ecosystem used to test the updater.

How will you know you've accomplished your goal?

This change will cause bundler 1 jobs to start failing with a clear error message.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review October 15, 2024 18:38
@jakecoffman jakecoffman requested a review from a team as a code owner October 15, 2024 18:38
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Oct 15, 2024
@kbukum1 kbukum1 force-pushed the hook-up-unsupported-package-managers branch 2 times, most recently from 8c9d418 to ff563b7 Compare October 15, 2024 21:53
@kbukum1 kbukum1 force-pushed the hook-up-unsupported-package-managers branch from ff563b7 to 71eab61 Compare October 15, 2024 22:08
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adding specs for update file commands
  • Adding specs for dependency snapshots
  • Removing unsupported package manager error from operations

Copy link
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbukum1 kbukum1 merged commit 7f120c2 into main Oct 15, 2024
184 of 185 checks passed
@kbukum1 kbukum1 deleted the hook-up-unsupported-package-managers branch October 15, 2024 23:32
@kbukum1 kbukum1 mentioned this pull request Oct 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants