handle all errors during an update job #10762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Oct 9, 2024
|
|
||
| public record ExpectedUpdateOperationResult : UpdateOperationResult | ||
| { | ||
| public string? ErrorDetailsRegex { get; init; } = null; |
There was a problem hiding this comment.
The actual error message can be large, so this gives an easy test target.
ryanbrandenburg
approved these changes
Oct 9, 2024
sachin-sandhu
force-pushed
the
dev/brettfo/nuget-update-catch-error
branch
from
cca185c
to
87f1ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding error handling last week I missed a spot to catch a generic
Exceptionand report it up the chain; this fixes that.Previously, the telemetry would classify a whole variety of failures under the category
Dependabot::SharedHelpers::HelperSubprocessFailed: No dotnet-tools.json file found.due to the first line in the command's output. Now we'll get properly grouped failures.I found in the logs where a NuGet server returned a
500and that made NuGet fail miserably but made for a great test case.