NPM: Handle 403 Forbidden when updating lockfiles#1013
Merged
Conversation
Contributor
Author
|
@greysteil does this seem legit? Not sure why this change is now returning a 403 Forbidden which we haven't handled before, will continue digging into this tomorrow. |
feelepxyz
force-pushed
the
fix-npmrc-registry-with-trailing-slash
branch
2 times, most recently
from
79ea5e6 to
ae7550d
Compare
Seems to handle the case when we auth against artifactory and get "Unable to authenticate, need: Basic realm="Artifactory Realm"" This seems to be caused by a trailing slash in the registry host as set in config variables. When we write this out in npmrc we add another trailing slash and this seems to cause the above error. Changing to a single trailing slash returns a 403 Forbidden error.
feelepxyz
force-pushed
the
fix-npmrc-registry-with-trailing-slash
branch
from
ae7550d to
7beb80c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to handle the case when we auth against artifactory and get
"Unable to authenticate, need: Basic realm="Artifactory Realm""
This seems to be caused by a trailing slash in the registry host as set
in config variables. When we write this out in npmrc we add another
trailing slash and this seems to cause the above error. Changing to a
single trailing slash returns a 403 Forbidden error.