adds handlers for bad registry response

dependabot · Jan 31, 2025 · 3638512 · 3638512
1 parent 4ee82e0
commit 3638512
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/common/lib/dependabot/errors.rb b/common/lib/dependabot/errors.rb
@@ -94,7 +94,7 @@ def self.fetcher_error_details(error)
       }
     when Dependabot::PrivateSourceBadResponse
       {
-        "error-type": "private_source_response_error",
+        "error-type": "private_source_bad_response",
         "error-detail": { source: error.source }
       }
     when Octokit::Unauthorized
@@ -177,7 +177,7 @@ def self.parser_error_details(error)
       }
     when Dependabot::PrivateSourceBadResponse
       {
-        "error-type": "private_source_response_error",
+        "error-type": "private_source_bad_response",
         "error-detail": { source: error.source }
       }
     when Dependabot::GitDependenciesNotReachable
@@ -277,7 +277,7 @@ def self.updater_error_details(error)
       }
     when Dependabot::PrivateSourceBadResponse
       {
-        "error-type": "private_source_response_error",
+        "error-type": "private_source_bad_response",
         "error-detail": { source: error.source }
       }
     when Dependabot::DependencyNotFound

diff --git a/docker/lib/dependabot/docker/update_checker.rb b/docker/lib/dependabot/docker/update_checker.rb
@@ -199,7 +199,7 @@ def tags_from_registry
           rescue *transient_docker_errors
             attempt ||= 1
             attempt += 1
-            raise if attempt > 3
+            raise PrivateSourceBadResponse, registry_hostname if attempt > 3
 
             retry
           end