Skip to content

fix running updater even though fetcher failed #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakecoffman merged 2 commits into from
Oct 28, 2022
+1 −0
Merged

fix running updater even though fetcher failed #30

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
245668e
fix running updater even though fetcher failed
jakecoffman Oct 27, 2022
338589d
Merge branch 'main' into jakecoffman/exit-code-on-fetch-failure
jakecoffman Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/infra/updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ func (u *Updater) InstallCertificates(ctx context.Context) error {

func userEnv(proxyURL string, apiPort int) []string {
return []string{
"GITHUB_ACTIONS=true", // sets exit code when fetch fails
fmt.Sprintf("http_proxy=%s", proxyURL),
fmt.Sprintf("HTTP_PROXY=%s", proxyURL),
fmt.Sprintf("https_proxy=%s", proxyURL),
Expand Down