Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Relay 0.8 support #33

Closed
wants to merge 5 commits into from

Conversation

edvinerikson
Copy link

The server is working fine.
However the client trashes the server markup due to Relay.Renderer renders null on the first render.
I have checked the discussion at facebook/relay#921 but I am not entirely sure what the best approach would be here.
RootContainer -> checkCache(container, route) -> true -> render Relay.ReadyStateRenderer
RootContainer -> checkCache(container, route) -> false -> render Relay.Renderer
?

Edvin Erikson added 4 commits April 20, 2016 19:18
Server is working fine.
The client uses Relay.Renderer which currently renders null for the
first render due to initial readyState. This causes it to trash the markup from the
server.
@edvinerikson
Copy link
Author

I tried the approach I suggested and it should work but it do not.
The server still works fine, however the client emits RelayQueryWriter: Could not find a type name for record RmFjdGlvbjoy. when it fetches from the server (works with server data). The problem is that Relay doesn't query the __typename field from the server.

@mattecapu
Copy link

It does work for me now

@edvinerikson
Copy link
Author

edvinerikson commented Apr 21, 2016

@mattecapu That's awesome! Thank you for trying it! Did you try the StarWars example or did you have your own app?

@mattecapu
Copy link

I tried with the example, no errors both on client and server
My app uses isomorphic-relay-router on top of isomorphic-relay, and I don't think it's compatible yet. What do you think?

@edvinerikson
Copy link
Author

Closing this out as of a800c70

@mattecapu No, it won't currently work as that lib relies on RootContainer which is removed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants