Enable asyncronous linting for pylint#3204
Enable asyncronous linting for pylint#3204oliverwiegers wants to merge 3 commits intodense-analysis:masterfrom oliverwiegers:master
Conversation
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
|
Hello the bot marked this PR as stale. The test ran successfully, but the Travis CI is stuck. |
Ping @w0rp (sorry, don't know who the other maintainers are) |
|
This will work with Another issue is that you can't mark a linter as optionally being one that only lints when you save a file or on any text edit. I've thought about making it so you can dynamically compute if a file can be checked or not, and I think I know how to make that possible now. I'll open an issue for that, do that first, and update this to use a version check. |
|
I've opened #3285 to support this. I want to get that one done now. It will open up a lot of new possibilities. |
|
Okay, is there currently any todo for me? |
|
No, I'll take care of it. You need some support from me to get this done. The stale bot should be configured to let things stay open if someone leaves a comment, so this PR should remain open now. |
|
I've merged parts of this in the command line now. I had to fix how Cheers! 🍻 |
When pylint.vim was written pylint wasn't able to read from stdin. As mentioned in issue 590 this causes the A.L.E. linting using pylint to not be async.
Since Pull request 2746 is merged, pylint is able to read from stdin.
I added the pylint flag
--from-stdinto the pylint call and changed ale_linters/python/pylint.vim so that ale is continuously linting python files using pylint.I haven't written additional tests, because the existing tests do cover my changes.
I have edited test/command_callback/test_pylint_command_callback.vader to call pylint the right way from pipenv.