Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable "enableProjectDiagnostics" on enable #1191

Merged

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Oct 23, 2024

The diagnostics from this setting cannot be suppressed by our plugin: #437 (comment). When users see diagnostics from both ts and deno-ts, this has always been the cause. So disable it for the workspace if it's enabled there or in user settings.

Non-exhaustive list of reports:
#66 (comment)
#466
#668 (comment)
#715
#1072
#1098
#1184
#1190

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@nayeemrmn nayeemrmn merged commit 0361a50 into denoland:main Oct 24, 2024
2 checks passed
@nayeemrmn nayeemrmn deleted the disable-enable-project-diagnostics branch October 24, 2024 12:58
@alumni
Copy link

alumni commented Nov 27, 2024

I think there might be a regression on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants