Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalize notebook cell filename in plugin #1103

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: normalize notebook cell filename in plugin #1103

merged 1 commit into from
Apr 4, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #1102.

@nayeemrmn nayeemrmn requested a review from dsherret April 4, 2024 16:25
dsherret
dsherret approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit e07355b into denoland:main Apr 4, 2024
2 checks passed
@nayeemrmn nayeemrmn deleted the notebook-cell-file-name branch April 4, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jupyter notebook requires enabling deno in settings.json to disable TS even when deno.json exists
2 participants
@nayeemrmn @dsherret