Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show a modal dialog after workspace init #1060

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

irbull
Copy link
Contributor

@irbull irbull commented Jan 31, 2024

Previously, the user was prompted with a few questions about their workspace configuration, making it clear that something was happening. Now that there is no more user input required, it is not clear that the extension is doing anything.

This change-set shows a show a modal info box to the user after the Deno workspace is initialized.

In a future commit, this should be replaced with a message to the status bar.

Previously, the user was prompted with a few questions about
their workspace configuration, making it clear that something was
happening. Now that there is no more user input required, it is not
clear that the extension is doing anything.

This change-set shows a show a modal info box to the user after the
Deno workspace is initialized.

In a future commit, this should be replaced with a message to the
status bar.
@CLAassistant
Copy link

CLAassistant commented Jan 31, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nayeemrmn nayeemrmn merged commit 9261c96 into denoland:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants