-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect fmt
option in deno.json
for auto imports
#856
Comments
I'm (also) willing to open a PR, @bartlomieju could you provide me some pointers on where to look at? |
@scarf005 I'll get back to you soon. I'm not entirely sure how to fix it yet. |
@scarf005 we are currently not providing formatting settings to function calls like https://github.com/denoland/deno/blob/80331d1fe5b85b829ac009fdc201c128b3427e11/cli/tsc/99_main_compiler.js#L1037 Probably providing the format settings there would fix this. We'd need to pass them into typescript via https://github.com/denoland/deno/blob/main/cli/lsp/tsc.rs |
@scarf005 are you interested in looking at this one? Otherwise I can look into it sometime in the next few weeks. |
I'll have a look this weekend |
indeed this was a lot more complex than i could handle. sorry i couldn't help more. |
Thanks for the info @scarf005. We'll look into it then. |
Is your feature request related to a problem? Please describe.
i use following
deno.jsonc
:however auto import feature will not respect
"semiColons": false
option and add semicolons at the end.Describe the solution you'd like
while the problem can be easily solved with
format on save
, respectingfmt
options would be appreciated.The text was updated successfully, but these errors were encountered: