Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing Deno breaks suggest.completeFunctionCalls #743

Closed
Tracked by #879
jorqensen opened this issue Nov 2, 2022 · 0 comments · Fixed by denoland/deno#20214
Closed
Tracked by #879

Initializing Deno breaks suggest.completeFunctionCalls #743

jorqensen opened this issue Nov 2, 2022 · 0 comments · Fixed by denoland/deno#20214
Labels
bug Something isn't working dx high priority

Comments

@jorqensen
Copy link

VSC offers the following options for auto completing function calls:

{
    "javascript.suggest.completeFunctionCalls": true,
    "typescript.suggest.completeFunctionCalls": true
}

This completes the function with parentheses and hints the parameters, along with tabbing to jump between them & the body.

However, once Deno is initialized, this stops working. I've also enabled: "deno.suggest.completeFunctionCalls": true in my settings, however this does not fix the issue. I am not sure if this setting is even relevant to the problem, might be?

To Reproduce

  1. Create new project
  2. Configure the following in settings.json:
{
    "javascript.suggest.completeFunctionCalls": true,
    "typescript.suggest.completeFunctionCalls": true,
    "deno.suggest.completeFunctionCalls": true
}

(Alternatively un-comment one or the other, every combination does not work.)

  1. Try and auto-complete anything, here's an exanple tested with .ts file that works outside a Deno project, but not in a Deno project:
const items: string[] = ['foo', 'bar', 'baz'];

items.map // auto-complete with Intellisense here.

Expected behavior

Expect suggest.completeFunctionCalls to work as expected.

Screenshots

Screenshots not relevant, unless a GIF is wanted.

Versions

VS Code: 1.73 (commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f) - Windows 11 (x64)
Deno: 1.27.0
Extension: 3.14.0
@dsherret dsherret added the bug Something isn't working label Nov 3, 2022
@bartlomieju bartlomieju mentioned this issue Jul 11, 2023
Closed
17 tasks
@nayeemrmn nayeemrmn mentioned this issue Aug 20, 2023
Merged
bartlomieju pushed a commit to denoland/deno that referenced this issue Aug 26, 2023
@nayeemrmn
fix(lsp): implement deno.suggest.completeFunctionCalls (#20214)
37292e7 
Fixes denoland/vscode_deno#743.
```ts
const items: string[] = ['foo', 'bar', 'baz'];

items.map
// ->
items.map(callbackfn) // auto-completes with argument placeholders.
```

---

We have our own setting for `suggest.completeFunctionCalls`, which must
be enabled:
```js
{
    "deno.suggest.completeFunctionCalls": true,
    // Re-implementation of:
    // "javascript.suggest.completeFunctionCalls": true,
    // "typescript.suggest.completeFunctionCalls": true,
}
```
But before this commit the actual implementation had been left as a TODO.
bartlomieju pushed a commit to denoland/deno that referenced this issue Aug 31, 2023
@nayeemrmn @bartlomieju
fix(lsp): implement deno.suggest.completeFunctionCalls (#20214)
4dcb410 
Fixes denoland/vscode_deno#743.
```ts
const items: string[] = ['foo', 'bar', 'baz'];

items.map
// ->
items.map(callbackfn) // auto-completes with argument placeholders.
```

---

We have our own setting for `suggest.completeFunctionCalls`, which must
be enabled:
```js
{
    "deno.suggest.completeFunctionCalls": true,
    // Re-implementation of:
    // "javascript.suggest.completeFunctionCalls": true,
    // "typescript.suggest.completeFunctionCalls": true,
}
```
But before this commit the actual implementation had been left as a TODO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dx high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lsp): implement deno.suggest.completeFunctionCalls nayeemrmn/deno
3 participants
@dsherret @jorqensen @bartlomieju