Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf_hooks): add basic node perf_hooks module #945

Conversation

douglasduteil
Copy link
Contributor

@douglasduteil douglasduteil commented Jun 1, 2021

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2021

CLA assistant check
All committers have signed the CLA.

@douglasduteil douglasduteil force-pushed the douglasduteil/feat-perf-hooks-add-basic-node-perf-hooks-module branch from 0dbf3be to ea4ff79 Compare June 1, 2021 02:10
@kt3k
Copy link
Member

kt3k commented Jun 1, 2021

@douglasduteil Thank you for your contribution! The change looks good to me. Could you run the formatter (deno fmt) to the added scripts?

@getspooky
Copy link
Contributor

@domharrington Please run deno --unstable lint

@douglasduteil
Copy link
Contributor Author

Done @kt3k @getspooky :)

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglasduteil LGTM. Thank you for your contribution!

@kt3k kt3k merged commit 282e0a3 into denoland:main Jun 2, 2021
@douglasduteil douglasduteil deleted the douglasduteil/feat-perf-hooks-add-basic-node-perf-hooks-module branch June 2, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants