Skip to content

Conversation

@timreichen
Copy link
Contributor

This PR removes the default addition of the [] brackets from formatter elements. This makes it easier to use a custom format without string slicing.

@timreichen timreichen requested a review from kt3k as a code owner May 24, 2025 09:16
@github-actions github-actions bot added the cli label May 24, 2025
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (ba1ee68) to head (350dccf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6678   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files         563      563           
  Lines       46676    46676           
  Branches     6573     6573           
=======================================
  Hits        44204    44204           
  Misses       2430     2430           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title refactor(cli/unstable): remove brackets from strings BREAKING(cli/unstable): change custom formatter rule May 26, 2025
@kt3k
Copy link
Member

kt3k commented May 26, 2025

Can you also update Custom Formatting example in jsdoc of the class?

@kt3k
Copy link
Member

kt3k commented May 26, 2025

This allows users to use other kinds of parens/brackes. This change makes sense to me.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 5e5d251 into denoland:main May 26, 2025
19 checks passed
@kt3k
Copy link
Member

kt3k commented May 26, 2025

The next @std/cli release will already include 3 breaking changes to ProgressBar #6406 #6409 #6430

Let's make this change as well at once instead of making breaking changes separately in multiple releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants