Skip to content

Conversation

@timreichen
Copy link
Contributor

@timreichen timreichen commented Mar 30, 2025

This allows for more complex regexps match checks.

@timreichen timreichen requested a review from kt3k as a code owner March 30, 2025 17:58
@github-actions github-actions bot added the toml label Mar 30, 2025
@codecov
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.57%. Comparing base (5c565de) to head (f664ec9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
toml/_parser.ts 91.30% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6538      +/-   ##
==========================================
- Coverage   94.58%   94.57%   -0.02%     
==========================================
  Files         579      579              
  Lines       43751    43703      -48     
  Branches     6494     6476      -18     
==========================================
- Hits        41383    41331      -52     
- Misses       2328     2329       +1     
- Partials       40       43       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title feat(toml): add Scanner match() method refactor(toml): add Scanner match() method Apr 7, 2025
@timreichen timreichen requested a review from kt3k April 10, 2025 22:04
@timreichen timreichen requested a review from kt3k April 18, 2025 06:31
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I also did some benchmark test. Now the entire toml/parse_test.ts pass slightly faster than the main with this change. Nice work

~/denoland/std $ g co -; hyperfine -w 10 "deno test toml/parse_test.ts"
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
Benchmark 1: deno test toml/parse_test.ts
  Time (mean ± σ):      86.1 ms ±  21.9 ms    [User: 61.8 ms, System: 25.5 ms]
  Range (min … max):    64.9 ms … 179.2 ms    33 runs
 
~/denoland/std $ g co -; hyperfine -w 10 "deno test toml/parse_test.ts"
Switched to branch 'toml-add-Scanner-match-method'
Your branch is up to date with 'timreichen/toml-add-Scanner-match-method'.
Benchmark 1: deno test toml/parse_test.ts
  Time (mean ± σ):      83.3 ms ±  16.8 ms    [User: 61.2 ms, System: 25.4 ms]
  Range (min … max):    67.6 ms … 142.8 ms    32 runs

@kt3k kt3k changed the title refactor(toml): add Scanner match() method perf(toml): add Scanner match() method, capturing numbers and bare key patterns using sticky regexp Apr 18, 2025
@kt3k kt3k merged commit 390845e into denoland:main Apr 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants