Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(regexp): escape leading digit #6208

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 23, 2024

This PR updates escape of @std/regexp. Now escape escapes the leading digit as recommended in #3656. This behavior is aligned with regexp-escape proposal ( https://github.com/tc39/proposal-regex-escaping, polyfill: https://npm.im/regexp.escape )

closes #3656

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.52%. Comparing base (4989ba7) to head (35f2606).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6208      +/-   ##
==========================================
- Coverage   96.52%   96.52%   -0.01%     
==========================================
  Files         533      534       +1     
  Lines       40871    40977     +106     
  Branches     6120     6134      +14     
==========================================
+ Hits        39451    39553     +102     
- Misses       1378     1382       +4     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

regexp/escape.ts Outdated Show resolved Hide resolved
@kt3k kt3k requested a review from bartlomieju December 10, 2024 07:41
@kt3k kt3k merged commit 5a597be into denoland:main Dec 10, 2024
18 checks passed
@kt3k kt3k deleted the fix-regexp-escape-leading-number branch December 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regexp.escape needs to escape leading digits
3 participants