Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(log): do not exec file handler examples in CI #6183

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Nov 13, 2024

std/log/file-handler examples generate logs.txt and it makes the repository modified state. That leads to the publishing failure https://github.com/denoland/std/actions/runs/11815536146/job/32916891866

This PR fixes the situation by ignoring examples in doc testing.

@kt3k kt3k requested a review from satyarohith November 13, 2024 10:59
@github-actions github-actions bot added the log label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (c6193ac) to head (88616a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6183      +/-   ##
==========================================
- Coverage   96.49%   96.10%   -0.39%     
==========================================
  Files         535      516      -19     
  Lines       41285    41127     -158     
  Branches     6165     6086      -79     
==========================================
- Hits        39836    39527     -309     
- Misses       1405     1547     +142     
- Partials       44       53       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt3k kt3k merged commit 8522627 into denoland:main Nov 13, 2024
19 checks passed
@kt3k kt3k deleted the do-not-exec-file-handler-example branch November 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants