-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(log): remove NOTSET
LogLevel
#6078
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 532 532
Lines 40819 40818 -1
Branches 6111 6111
=======================================
Hits 39416 39416
Misses 1360 1360
+ Partials 43 42 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There seem some dependencies to this symbol. https://github.com/search?q=NOTSET+language%3ATypeScript+std%2Flog&type=code I don't find much value to this change, while it has some negative effects to the above users. |
The log module is not stable, so breaking changes for v1 should not be a dealbreaker imo. |
The created logger doesn't have any handler. It means the logger doesn't do anything. I wonder if this change would impact the user in any meaningful way.. |
Changes
This PR removes the
NOTSET
LogLevel
.Reasoning
Instead of
NOTSET
loggers should be initialized with the default setLogLevel
(which isINFO
).