Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(log): remove NOTSET LogLevel #6078

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Sep 28, 2024

Changes
This PR removes the NOTSET LogLevel.

Reasoning
Instead of NOTSET loggers should be initialized with the default set LogLevel (which is INFO).

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (93e0cd6) to head (ab0ddd3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6078   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         532      532           
  Lines       40819    40818    -1     
  Branches     6111     6111           
=======================================
  Hits        39416    39416           
  Misses       1360     1360           
+ Partials       43       42    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kt3k kt3k added the feedback welcome We want community's feedback on this issue or PR label Oct 8, 2024
@kt3k
Copy link
Member

kt3k commented Nov 14, 2024

There seem some dependencies to this symbol. https://github.com/search?q=NOTSET+language%3ATypeScript+std%2Flog&type=code

I don't find much value to this change, while it has some negative effects to the above users.

@timreichen
Copy link
Contributor Author

The log module is not stable, so breaking changes for v1 should not be a dealbreaker imo.
To me this seems to be a question of principal: Does NOTSET as a loglevel make sense in the ts/js context? I would argue no. WDYT?

@kt3k
Copy link
Member

kt3k commented Nov 22, 2024

The created logger doesn't have any handler. It means the logger doesn't do anything. I wonder if this change would impact the user in any meaningful way..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback welcome We want community's feedback on this issue or PR log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants