Skip to content

refactor(cli): minor cleanups #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024
Merged

refactor(cli): minor cleanups #5628

merged 2 commits into from
Aug 5, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 5, 2024

Addresses #5607 (comment)

The following tests pass:

import { assertEquals } from "@std/assert";

Deno.test("isNumber should return true for valid numbers", () => {
  assertEquals(isNumber("123"), true);
  assertEquals(isNumber("-456"), true);
  assertEquals(isNumber("0"), true);
  assertEquals(isNumber("3.14"), true);
  assertEquals(isNumber("-2.5"), true);
  assertEquals(isNumber("1e3"), true);
  assertEquals(isNumber("-5e-2"), true);
  assertEquals(isNumber("0x10"), true);
});

Deno.test("isNumber should return false for invalid numbers", () => {
  assertEquals(isNumber("abc"), false);
  assertEquals(isNumber("123abc"), false);
  assertEquals(isNumber("12.34.56"), false);
  assertEquals(isNumber("1e"), false);
  assertEquals(isNumber("e3"), false);
  assertEquals(isNumber("0xg"), false);
  assertEquals(isNumber(""), false);
  assertEquals(isNumber("\t"), false);
  assertEquals(isNumber("-Infinity"), false);
  assertEquals(isNumber("Infinity"), false);
});

@iuioiua iuioiua requested a review from kt3k as a code owner August 5, 2024 08:13
@iuioiua iuioiua enabled auto-merge (squash) August 5, 2024 08:13
@github-actions github-actions bot added the cli label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (ddfeff9) to head (cba62f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5628      +/-   ##
==========================================
- Coverage   96.38%   96.38%   -0.01%     
==========================================
  Files         466      466              
  Lines       37591    37588       -3     
  Branches     5541     5542       +1     
==========================================
- Hits        36231    36228       -3     
  Misses       1318     1318              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit ddd853d into main Aug 5, 2024
13 checks passed
@iuioiua iuioiua deleted the cli-cleanup branch August 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants