-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(datetime): remove Tokenizer
class
#5622
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5622 +/- ##
==========================================
- Coverage 96.44% 96.21% -0.24%
==========================================
Files 468 468
Lines 38221 38152 -69
Branches 5542 5536 -6
==========================================
- Hits 36864 36707 -157
- Misses 1315 1403 +88
Partials 42 42 ☔ View full report in Codecov by Sentry. |
Rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rules
Tokenizer
class
Changes
This PR removes the ability to add custom rules to
DateTimeFormatter
. This allows for simplifications:DateTimeFormatter
classTokenizer
class in favour offormatToParts()
functionReasoning
The
DateTimeFormatter
file is private.