Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): remove Tokenizer class #5622

Merged
merged 7 commits into from
Aug 6, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Aug 2, 2024

Changes
This PR removes the ability to add custom rules to DateTimeFormatter . This allows for simplifications:

  • removes custom rules for private DateTimeFormatter class
  • removes Tokenizer class in favour of formatToParts() function
  • removes custom rules tests

Reasoning
The DateTimeFormatter file is private.

@timreichen timreichen requested a review from kt3k as a code owner August 2, 2024 11:27
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (f7e3cd5) to head (1f8c78f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5622      +/-   ##
==========================================
- Coverage   96.44%   96.21%   -0.24%     
==========================================
  Files         468      468              
  Lines       38221    38152      -69     
  Branches     5542     5536       -6     
==========================================
- Hits        36864    36707     -157     
- Misses       1315     1403      +88     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(datetime): remove custom Rules refactor(datetime): remove custom Rules Aug 6, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. LGTM.

kt3k
kt3k previously approved these changes Aug 6, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k dismissed their stale review August 6, 2024 14:36

let me check a bit more

@iuioiua iuioiua changed the title refactor(datetime): remove custom Rules refactor(datetime): remove Tokenizer class Aug 6, 2024
@iuioiua iuioiua merged commit 0dae9ce into denoland:main Aug 6, 2024
14 checks passed
@timreichen timreichen deleted the datetime-simplify-rules branch August 6, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants