fix(async): abortable should not change original outputs

[raaymax]

Related to this PR: #5560
And this issue #3518

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (9d87893) to head (81996c8).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5609      +/-   ##
==========================================
- Coverage   96.38%   96.01%   -0.37%     
==========================================
  Files         466      466              
  Lines       37588    37590       +2     
  Branches     5541     5510      -31     
==========================================
- Hits        36228    36091     -137     
- Misses       1318     1457     +139     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[raaymax]

There is still small difference in types of return function argument between normalIterator and abortableIterator.
But this can't be fixed without changing AsyncIterable<T> type.
denoland/deno#24837

[iuioiua]

Nice work. Can you please also move the return() from the catch block to a finally block? I believe that should be the correct way to do it.

[raaymax]

As you wish but this way, the function will be called twice if no exception occurs.

[iuioiua]

In that case, we'd likely need to at a let returned = false before the try/catch, set it do true when done is truthy, then check if that value is true in the finally block. We should also have a test case for that too.

[kt3k]

In that case, we'd likely need to at a let returned = false before the try/catch, set it do true when done is truthy, then check if that value is true in the finally block.

Sounds like the same thing can be achieved by calling it?.return() in catch block?

[raaymax]

I thought so too and thats exactly what I did in the first place.
In my opinion, using a boolean flag for this purpose is just ugly, but it's not my decision to make.
You need to decide on one solution here.

[iuioiua]

Apologies. What the catch previously achieved didn't click with me. I've reverted that change now. Now, LGTM. Thank you.