Skip to content

BREAKING(fmt): rename PrettyDurationOptions to FormatOptions #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 31, 2024

What's changed

This PR renames PrettyDurationOptions to FormatOptions.

Motivation

The option object types are named with the convention of FooOptions where Foo is the function name which the option is used for. This PR aligns the option object type for format function to this convention.

Migration

-import type { PrettyDurationOptions } from "@std/fmt/duration";
+import type { FormatOptions as PrettyDurationOptions } from "@std/fmt/duration";

@github-actions github-actions bot added the fmt label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (3d09aa3) to head (add7894).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5591   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         465      465           
  Lines       37727    37727           
  Branches     5570     5570           
=======================================
  Hits        36404    36404           
  Misses       1282     1282           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

/**
* Whether to ignore zero values.
* With style="narrow" | "full", all zero values are ignored.
* With style="digital", only values in the ends are ignored.
*/
ignoreZero: boolean;
ignoreZero?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @default tag.

@kt3k kt3k merged commit c084459 into denoland:main Jul 31, 2024
13 checks passed
@kt3k kt3k deleted the breaking-fmt-rename-pretty-duration-options-to-format-options branch July 31, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants