BREAKING(ini): reduce options for stringify, make FormattingOptions type private
#5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
changed the title
FormattingOptions type privatestringify, make FormattingOptions type private
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
==========================================
- Coverage 96.49% 96.49% -0.01%
==========================================
Files 465 465
Lines 37772 37770 -2
Branches 5580 5578 -2
==========================================
- Hits 36447 36445 -2
Misses 1283 1283
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
approved these changes
Jul 29, 2024
Co-authored-by: Asher Gomez <[email protected]>
Co-authored-by: Asher Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
commentChar,assignment, anddeduplicateoptions fromstringfiyoptions.deduplicateis no longer relevant as we dropped the support ofIniMap, which was only meaningful withIniMapcommentCharis no longer relevant as stringify doesn't support comments in output.assignmentoption as=seems the only common character for assignment inINI.This PR also make
FormattingOptionsprivate as it's no longer reasonable to keep it public.related #5562