Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): add writeNode options #5409

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces boolean params with options object for more clarity.
  • removes default values

@timreichen timreichen requested a review from kt3k as a code owner July 11, 2024 07:50
@github-actions github-actions bot added the yaml label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.

Project coverage is 96.35%. Comparing base (e29f946) to head (2570b1f).

Files Patch % Lines
yaml/_dumper.ts 83.33% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5409      +/-   ##
==========================================
- Coverage   96.36%   96.35%   -0.01%     
==========================================
  Files         458      458              
  Lines       37727    37768      +41     
  Branches     5576     5576              
==========================================
+ Hits        36354    36391      +37     
- Misses       1331     1335       +4     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems better for readability to me.

LGTM

@kt3k kt3k merged commit 9a32225 into denoland:main Jul 11, 2024
16 checks passed
@timreichen timreichen deleted the yaml-add-writeNode-options-object branch July 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants