Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): fix onWarning arg type #5395

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner July 10, 2024 19:16
@github-actions github-actions bot added the yaml label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (ef28e13) to head (8485225).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5395      +/-   ##
==========================================
- Coverage   96.35%   96.35%   -0.01%     
==========================================
  Files         458      458              
  Lines       37751    37750       -1     
  Branches     5576     5576              
==========================================
- Hits        36374    36373       -1     
  Misses       1335     1335              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Sidenote: this reminds me that we need to solve #5340.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you please also make the same change to ParseOptions.onWarning?

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@iuioiua iuioiua merged commit edacfa8 into denoland:main Jul 12, 2024
13 checks passed
@timreichen timreichen deleted the yaml-fix-onWarning-types branch August 17, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants