refactor(yaml): make Type generic
#5394
Merged
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5394 +/- ##
=======================================
Coverage 96.35% 96.36%
=======================================
Files 458 458
Lines 37729 37726 -3
Branches 5576 5576
=======================================
Hits 36353 36353
+ Misses 1334 1331 -3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
Type generic
iuioiua
suggested changes
Jul 11, 2024
kt3k
reviewed
Jul 11, 2024
yaml/_type/set.ts
Outdated
| @@ -5,8 +5,7 @@ | |||
|
|
|||
| import type { Type } from "../_type.ts"; | |||
|
|
|||
| // deno-lint-ignore no-explicit-any | |||
| function resolveYamlSet(data: any): boolean { | |||
| function resolveYamlSet(data: Record<PropertyKey, unknown>): boolean { | |||
There was a problem hiding this comment.
Suggested change
| function resolveYamlSet(data: Record<PropertyKey, unknown>): boolean { | |
| function resolveYamlSet(data: ResultType | null): boolean { |
There was a problem hiding this comment.
Actually, that doesn't work, because result type could also be an object or string.
There was a problem hiding this comment.
I think we should revert this to any as we don't know what types are actually passed here.
There was a problem hiding this comment.
It must be an object or for (const key in data) {...} would throw no?
Co-authored-by: Yoshiya Hinosawa <[email protected]>
Co-authored-by: Asher Gomez <[email protected]>
iuioiua
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typeanytypes