refactor(yaml): remove nested functions #5389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5389 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 458 458
Lines 37726 37727 +1
Branches 5576 5576
=======================================
+ Hits 36353 36354 +1
Misses 1331 1331
Partials 42 42 ☔ View full report in Codecov by Sentry. |
iuioiua
reviewed
Jul 10, 2024
yaml/_dumper.ts
Outdated
| @@ -533,7 +533,7 @@ function writeScalar( | |||
| level: number, | |||
| isKey: boolean, | |||
| ) { | |||
| state.dump = ((): string => { | |||
| const createDump = () => { | |||
There was a problem hiding this comment.
We typically reserve the arrow function syntax for anonymous functions. Changing...
There was a problem hiding this comment.
Yes, but since this functions is now a method of DumperState, you would need to bind this with a regular function, right?
|
Please rebase |
iuioiua
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.