Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): move state functions inside class #5388

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

timreichen
Copy link
Contributor

  • moves all state modifying functions inside state class
  • modifies generateNextLine() and testImplicitResolving() arguments

Note: The goal is to separate functions that modify the state and functions that do not.

@timreichen timreichen requested a review from kt3k as a code owner July 10, 2024 15:30
@github-actions github-actions bot added the yaml label Jul 10, 2024
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 69 lines in your changes missing coverage. Please review.

Project coverage is 96.34%. Comparing base (3209065) to head (878cd88).

Files Patch % Lines
yaml/_dumper.ts 78.57% 67 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5388      +/-   ##
==========================================
- Coverage   96.34%   96.34%   -0.01%     
==========================================
  Files         458      458              
  Lines       37757    37752       -5     
  Branches     5576     5576              
==========================================
- Hits        36376    36371       -5     
  Misses       1338     1338              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iuioiua iuioiua merged commit 56d7c43 into denoland:main Jul 10, 2024
13 checks passed
@timreichen timreichen deleted the yaml-move-state-functions branch August 17, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants