Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(front-matter): replace regexp objects with maps #5379

Merged
merged 3 commits into from
Jul 10, 2024
Merged

refactor(front-matter): replace regexp objects with maps #5379

merged 3 commits into from
Jul 10, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces RECOGNIZE_REGEXP_MAP and EXTRACT_REGEXP_MAP objects with maps

@timreichen timreichen requested a review from kt3k as a code owner July 10, 2024 08:15
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (c356e39) to head (8736b6d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5379   +/-   ##
=======================================
  Coverage   96.33%   96.34%           
=======================================
  Files         458      458           
  Lines       37767    37764    -3     
  Branches     5576     5575    -1     
=======================================
  Hits        36383    36383           
+ Misses       1341     1338    -3     
  Partials       43       43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iuioiua
iuioiua approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@iuioiua iuioiua merged commit adcfb5f into denoland:main Jul 10, 2024
13 checks passed
@timreichen timreichen deleted the front_matter-regexp-maps branch July 10, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
front-matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua