Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(front-matter): remove unknown from Format union type #5367

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

timreichen
Copy link
Contributor

  • removes unknown as a format and makes handles all invalid formats the same.

@timreichen timreichen requested a review from kt3k as a code owner July 9, 2024 11:06
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.32%. Comparing base (474d6f3) to head (45f971b).

Files Patch % Lines
front_matter/_create_extractor.ts 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5367   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         458      458           
  Lines       37774    37771    -3     
  Branches     5577     5576    -1     
=======================================
- Hits        36385    36383    -2     
+ Misses       1348     1345    -3     
- Partials       41       43    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k changed the title BREAKING(front_matter): remove unknown Format BREAKING(front-matter): remove unknown Format Jul 9, 2024
@iuioiua iuioiua changed the title BREAKING(front-matter): remove unknown Format BREAKING(front-matter): remove unknown from Format union type Jul 9, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 094d184 into denoland:main Jul 9, 2024
13 checks passed
@timreichen timreichen deleted the front_matter-remove-unknown-format branch July 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants