Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove Any type #5306

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Jul 4, 2024

  • replaces Any type with any
  • adds lint ignore rules
  • replaces any with unknown in type assertion functions

Note: The point of this PR is to expose any as a suboptimal type, which should be replaced where possible.

@timreichen timreichen requested a review from kt3k as a code owner July 4, 2024 11:50
@github-actions github-actions bot added the yaml label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.33%. Comparing base (1f26aa5) to head (b3e0447).

Files Patch % Lines
yaml/_type/map.ts 0.00% 1 Missing ⚠️
yaml/_type/seq.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5306   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         458      458           
  Lines       37849    37867   +18     
  Branches     5619     5619           
=======================================
+ Hits        36460    36478   +18     
  Misses       1348     1348           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 9dafbfb into denoland:main Jul 9, 2024
13 checks passed
@timreichen timreichen deleted the yaml-remove-Any branch July 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants