Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove repeat helper function #5303

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces repeat helper function with built in String.prototype.repeat()

@timreichen timreichen requested a review from kt3k as a code owner July 4, 2024 07:46
@github-actions github-actions bot added the yaml label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (6a28a21) to head (72fc6ef).

Files Patch % Lines
yaml/_dumper.ts 50.00% 1 Missing ⚠️
yaml/_loader.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5303      +/-   ##
==========================================
- Coverage   95.81%   95.81%   -0.01%     
==========================================
  Files         457      457              
  Lines       37893    37879      -14     
  Branches     5568     5567       -1     
==========================================
- Hits        36307    36293      -14     
  Misses       1546     1546              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit 9d5d887 into denoland:main Jul 4, 2024
13 checks passed
timreichen added a commit to timreichen/std that referenced this pull request Jul 4, 2024
@timreichen timreichen deleted the yaml-remove-repeat branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants