Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(csv): remove runeCount() function #5298

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

timreichen
Copy link
Contributor

  • replaces runeCount() with length of strings

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.81%. Comparing base (73f236d) to head (12b53eb).

Files Patch % Lines
csv/_io.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5298      +/-   ##
==========================================
- Coverage   95.81%   95.81%   -0.01%     
==========================================
  Files         457      457              
  Lines       37907    37895      -12     
  Branches     5568     5568              
==========================================
- Hits        36321    36309      -12     
  Misses       1546     1546              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua merged commit c58879e into denoland:main Jul 4, 2024
13 checks passed
@kt3k
Copy link
Member

kt3k commented Jul 4, 2024

This makes the count of characters broken for surrogate pair characters

> "🐱".length
2
> Array.from("🐱").length
1

@timreichen
Copy link
Contributor Author

This makes the count of characters broken for surrogate pair characters

> "🐱".length
2
> Array.from("🐱").length
1

Ah damn, sorry for the oversight. I think we should add a test for that.

@timreichen timreichen deleted the csv-remove-runeCount branch July 4, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants