Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(yaml): release [email protected] #5264

Merged
merged 2 commits into from
Jul 25, 2024
Merged

chore(yaml): release [email protected] #5264

merged 2 commits into from
Jul 25, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 3, 2024 •
edited
Loading

Docs: https://jsr.io/@std/[email protected]

To be merged July 23.

Closes #5015

@iuioiua iuioiua requested a review from kt3k as a code owner July 3, 2024 01:53
@github-actions github-actions bot added the yaml label Jul 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (55297e9) to head (cc2ae67).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5264   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         465      465           
  Lines       37705    37705           
  Branches     5561     5561           
=======================================
  Hits        36312    36312           
  Misses       1351     1351           
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

satyarohith
satyarohith reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I think these two can be achievable before release to get 100% score?
CleanShot 2024-07-22 at 11 20 16@2x

@kt3k
Copy link
Member

kt3k commented Jul 22, 2024

@satyarohith I think these issue are addressed in the latest RC version (1.0.0-rc.4) (I guess the score is calculated based on the last non-prerelease version (0.224.3)

@satyarohith satyarohith mentioned this pull request Jul 22, 2024
Open
satyarohith
satyarohith approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt3k thanks Yoshiya! I opened an issue in JSR to support score for pre-release versions.

LGTM in case the issues are already addressed.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 22, 2024

I'm not yet confident testing is sufficient, namely that options all do what they should and that Types are sufficently tested. Let's work a little more on this. I should have time to focus on this tomorrow.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 24, 2024

Testing LGTM now

kt3k
kt3k approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 42693da into main Jul 25, 2024
17 checks passed
@iuioiua iuioiua deleted the yaml-1 branch July 25, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyarohith satyarohith satyarohith approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stabilize @std/yaml
3 participants
@iuioiua @kt3k @satyarohith