Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(yaml): share char constants #5246

Merged
merged 6 commits into from
Jul 2, 2024
Merged

refactor(yaml): share char constants #5246

merged 6 commits into from
Jul 2, 2024

Conversation

timreichen
Copy link
Contributor

  • moves shared char constants into one file

@timreichen timreichen requested a review from kt3k as a code owner July 2, 2024 09:02
@github-actions github-actions bot added the yaml label Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.11538% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.46%. Comparing base (8420b13) to head (3435860).

Files Patch % Lines
yaml/_dumper/dumper.ts 94.54% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5246   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         460      461    +1     
  Lines       37963    38003   +40     
  Branches     5536     5536           
=======================================
+ Hits        36241    36281   +40     
  Misses       1680     1680           
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k
kt3k reviewed Jul 2, 2024
View reviewed changes
yaml/_loader/loader.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the typo Yoshiya pointed out is fixed.

kt3k
kt3k approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua enabled auto-merge (squash) July 2, 2024 09:37
@iuioiua iuioiua merged commit df26c6d into denoland:main Jul 2, 2024
15 checks passed
@timreichen timreichen deleted the yaml-add-chars-file branch August 17, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timreichen @kt3k @iuioiua