Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): simplify schema #5236

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Jul 1, 2024

Changes

  • removes SchemaDefinition and replaces it with Schema
  • introduces SCHEMA_MAP and removes replaceSchemaNameWithSchemaClass
  • uses keyof typeof SCHEMA_MAP instead of hardcoded strings
  • replaces optional options with default empty option object for stringify(), parse() and parseAll()

@timreichen timreichen requested a review from kt3k as a code owner July 1, 2024 11:19
@github-actions github-actions bot added the yaml label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (b11514e) to head (86010f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5236      +/-   ##
==========================================
+ Coverage   94.95%   94.98%   +0.02%     
==========================================
  Files         460      460              
  Lines       38073    38059      -14     
  Branches     5549     5543       -6     
==========================================
- Hits        36154    36150       -4     
+ Misses       1878     1868      -10     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yaml/stringify.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thank you.

@iuioiua iuioiua merged commit b15707d into denoland:main Jul 1, 2024
15 checks passed
@timreichen timreichen deleted the simplify-yaml-schema branch July 2, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants