Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): fix validation of nth param in toHaveBeenNthCalledWith matcher #5227

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 1, 2024

This PR fixes the validation of nth argument of toHaveBeenNthCalledWith matcher.

@github-actions github-actions bot added the expect label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.73%. Comparing base (90025e9) to head (4a19777).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5227   +/-   ##
=======================================
  Coverage   94.72%   94.73%           
=======================================
  Files         467      467           
  Lines       38143    38143           
  Branches     5510     5511    +1     
=======================================
+ Hits        36131    36134    +3     
+ Misses       1974     1971    -3     
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@kt3k kt3k merged commit 335e073 into denoland:main Jul 1, 2024
15 checks passed
@kt3k kt3k deleted the fix-nth-called-with branch July 1, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants