Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(path): release [email protected] #5203

Merged
merged 5 commits into from
Jul 10, 2024
Merged

chore(path): release [email protected] #5203

merged 5 commits into from
Jul 10, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 1, 2024

To be merged July 4.

The latest API docs: https://jsr.io/@std/[email protected]/doc

Closes #4922

@iuioiua iuioiua requested a review from kt3k as a code owner July 1, 2024 03:17
@github-actions github-actions bot added the path label Jul 1, 2024
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (7bd1f18) to head (8b438ac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5203   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         458      458           
  Lines       37770    37770           
  Branches     5576     5576           
=======================================
  Hits        36382    36382           
  Misses       1345     1345           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jul 4, 2024

memo:

  • There are 2 types with the same description: GlobOptions vs GlobToRegExpOptions
  • FormatInputPathObject doesn't seem aligned to the naming convention

deno.json Show resolved Hide resolved
Co-authored-by: Asher Gomez <[email protected]>
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I am happy with this API

@iuioiua iuioiua merged commit f20b580 into main Jul 10, 2024
13 checks passed
@iuioiua iuioiua deleted the path-1 branch July 10, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stabilize @std/path
3 participants