Skip to content

fix(testing): Throw error eagerly when insufficient permissions are granted to write to snapshot file in update mode #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

bcheidemann
Copy link
Contributor

Fixes #5155

…ranted to write to snapshot file in update mode
@bcheidemann bcheidemann requested a review from kt3k as a code owner June 30, 2024 22:10
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (b18d1a0) to head (a486668).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5201   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files         467      467           
  Lines       37820    37828    +8     
  Branches     5491     5494    +3     
=======================================
+ Hits        35719    35727    +8     
  Misses       2062     2062           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit d6c3170 into denoland:main Jul 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants