fix(yaml): fix !!pairs parsing
#5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
commented
Jun 28, 2024
| @@ -9,6 +9,8 @@ import type { Any } from "../_utils.ts"; | |||
| const _toString = Object.prototype.toString; | |||
|
|
|||
| function resolveYamlPairs(data: Any[][]): boolean { | |||
| if (data === null) return true; | |||
There was a problem hiding this comment.
This check exists in the original (js-yaml). ref: https://github.com/nodeca/js-yaml/blob/0d3ca7a27b03a6c974790a30a89e456007d62976/lib/type/pairs.js#L8
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5192 +/- ##
==========================================
+ Coverage 94.38% 94.44% +0.05%
==========================================
Files 467 467
Lines 37819 37820 +1
Branches 5485 5491 +6
==========================================
+ Hits 35696 35719 +23
+ Misses 2085 2062 -23
- Partials 38 39 +1 ☔ View full report in Codecov by Sentry. |
iuioiua
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of empty pairs, and also adds the test cases for parsing various
!!pairspatterns.