Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): rename YAMLError to YamlError #5149

Merged
merged 2 commits into from
Jun 27, 2024
Merged

refactor(yaml): rename YAMLError to YamlError #5149

merged 2 commits into from
Jun 27, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 26, 2024

This aligns the class name with our naming convention.

@github-actions github-actions bot added the yaml label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.31%. Comparing base (162e000) to head (d9bba9f).

Files Patch % Lines
yaml/_dumper/dumper.ts 33.33% 4 Missing ⚠️
yaml/_loader/loader.ts 75.00% 1 Missing ⚠️
yaml/schema.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5149   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files         470      470           
  Lines       37941    37941           
  Branches     5388     5388           
=======================================
  Hits        35405    35405           
  Misses       2493     2493           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua marked this pull request as ready for review June 27, 2024 02:56
@iuioiua iuioiua requested a review from kt3k as a code owner June 27, 2024 02:56
@kt3k
Copy link
Member

kt3k commented Jun 27, 2024

YAMLError doesn't seem exposed as a public API. Is this a breaking change? https://jsr.io/@std/yaml/doc

@iuioiua iuioiua changed the title BREAKING(yaml): rename YAMLError to YamlError refactor(yaml): rename YAMLError to YamlError Jun 27, 2024
@iuioiua
Copy link
Contributor Author

iuioiua commented Jun 27, 2024

Good catch! Changed to refactor. I'll make this public in another PR. It should be public for error-handling purposes.

@iuioiua iuioiua enabled auto-merge (squash) June 27, 2024 05:54
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit ef4231e into main Jun 27, 2024
15 checks passed
@iuioiua iuioiua deleted the yaml-error branch June 27, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants