test(testing): improve FakeTime testing
#5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5123 +/- ##
==========================================
+ Coverage 92.74% 92.78% +0.04%
==========================================
Files 480 480
Lines 38337 38337
Branches 5396 5400 +4
==========================================
+ Hits 35555 35572 +17
+ Misses 2726 2710 -16
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. |
iuioiua
suggested changes
Jun 24, 2024
| () => { | ||
| time.now = 999; | ||
| }, | ||
| Error, |
There was a problem hiding this comment.
Not for this PR, but we should throw RangeError.
iuioiua
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test line coverage of
testing/time.tsfrom 85.22% to 93.08% (The missed lines are reduced from 57 to 22)part of #3713