Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): reland cleanup parse_args.ts #4487

Merged
merged 26 commits into from
Mar 16, 2024
Merged

refactor(cli): reland cleanup parse_args.ts #4487

merged 26 commits into from
Mar 16, 2024

Conversation

timreichen
Copy link
Contributor

timreichen and others added 26 commits January 13, 2024 13:13
@timreichen
initial commit
a8399f7
@timreichen
fix typo
a05f6eb
@timreichen
rename negated capturing group
e80f651
@timreichen
update nested functions
92afb81
@timreichen
update
295dc69
@timreichen
simplify setNested
54fe5fa
@timreichen
update
fd9bdbc
@timreichen
add parseBooleanValue
2ffa7bd
@timreichen
update
da721ff
@timreichen
remove unknown value type
5ddc2fe
@timreichen
rename fns
92611b5
@timreichen
update
734ad6a
@timreichen
Merge branch 'main' into log_cleanup_parse_args
e4657c9
@timreichen
Merge branch 'main' into log_cleanup_parse_args
37a9c71
@timreichen
Merge branch 'main' into log_cleanup_parse_args
f814cdc
@timreichen
Merge branch 'main' into cli_cleanup_parse_args
eb7e5d4
@timreichen @iuioiua
Update parse_args.ts
279cd7b 
Co-authored-by: Asher Gomez <[email protected]>
@timreichen
Merge branch 'main' into log_cleanup_parse_args
387f6e6
@timreichen @iuioiua
Update cli/parse_args.ts
5435257 
Co-authored-by: Asher Gomez <[email protected]>
@timreichen
Merge branch 'main' into log_cleanup_parse_args
a28814e
@timreichen
update
fec7f66
@timreichen
Merge branch 'denoland:main' into log_cleanup_parse_args
4aaadbd
@timreichen
revert to letters.entries()
bf7ff1b
@timreichen
Merge branch 'main' into cli_cleanup_parse_args
f526134
@timreichen
Merge branch 'denoland:main' into log_cleanup_parse_args
fc8eb94
@timreichen
fix alias bug
5383601
@timreichen timreichen requested a review from kt3k as a code owner March 14, 2024 08:50
@github-actions github-actions bot added the cli label Mar 14, 2024
@timreichen timreichen mentioned this pull request Mar 14, 2024
Merged
@iuioiua iuioiua changed the title refactor(cli): cleanup parse_args.ts 2 refactor(cli): reland cleanup parse_args.ts Mar 16, 2024
iuioiua
iuioiua approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua
Copy link
Contributor

iuioiua commented Mar 16, 2024

PTAL @kt3k

kt3k
kt3k approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit f6e4a07 into denoland:main Mar 16, 2024
12 checks passed
@timreichen timreichen deleted the log_cleanup_parse_args branch March 16, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseArgs duplicates collected + aliased arguments
3 participants
@timreichen @iuioiua @kt3k